Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate default tilematrixset #802

Merged
merged 3 commits into from
Mar 22, 2024
Merged

deprecate default tilematrixset #802

merged 3 commits into from
Mar 22, 2024

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented Mar 21, 2024 •
edited
Loading

ref #801

This PR removes non-prefixed /tileMatrixSetId endpoints for /tilejson.json, /tiles, /map and /WMTSCapabilities.xml, which now makes tileMatrixSetId a required path parameter

# Before
/cog/tiles/{z}/{x}/{y} 
/cog/tilejson.json
/cog/map
/cog/WMTSCapabilities.xml

# Now
/cog/tiles/WebMercatorQuad/{z}/{x}/{y} 
/cog/WebMercatorQuad/tilejson.json
/cog/WebMercatorQuad/map
/cog/WebMercatorQuad/WMTSCapabilities.xml

@vincentsarago vincentsarago added enhancement New feature or request breaking change labels Mar 21, 2024
@vincentsarago vincentsarago self-assigned this Mar 21, 2024
vincentsarago
vincentsarago commented Mar 21, 2024
View reviewed changes
src/titiler/core/titiler/core/factory.py
r"/tiles/{z}/{x}/{y}@{scale}x.{format}",
**img_endpoint_params,
deprecated=True,
)
Copy link
Member Author

@vincentsarago vincentsarago Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we just deprecate the endpoints but we will remove them in 0.19

@vincentsarago vincentsarago merged commit b24b6b5 into main Mar 22, 2024
10 checks passed
@vincentsarago vincentsarago deleted the feature/deprecated-default-tilematrixset branch March 22, 2024 17:48
@vincentsarago vincentsarago mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vincentsarago vincentsarago

Labels
breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vincentsarago